Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build no tests for ARM #1599

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Nov 5, 2024

The cross-compilatiion currently takes more than 6 hours and is then cancelled by GitHub actions.
We thus disable the building and execution of unit tests for the ARM64 build.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (39e63b4) to head (f3a345e).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   89.08%   89.11%   +0.03%     
==========================================
  Files         371      371              
  Lines       34437    34504      +67     
  Branches     3899     3906       +7     
==========================================
+ Hits        30677    30748      +71     
+ Misses       2486     2473      -13     
- Partials     1274     1283       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot. TODOs:

  1. Remove ifs in docker-publish.yml
  2. Remove debug messages from Dockerfile
  3. Only run ctest if tests were compiled

@joka921 joka921 merged commit 80938b7 into ad-freiburg:master Nov 7, 2024
18 checks passed
@sparql-conformance
Copy link

Copy link

sonarqubecloud bot commented Nov 7, 2024

ullingerc pushed a commit to ullingerc/qlever that referenced this pull request Nov 12, 2024
The cross-compilatiion currently takes more than 6 hours and is then cancelled by GitHub actions.
We thus disable the building and execution of unit tests for the ARM64 build.
@joka921 joka921 deleted the docker-push-no-tests branch December 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants