-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build no tests for ARM #1599
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
+ Coverage 89.08% 89.11% +0.03%
==========================================
Files 371 371
Lines 34437 34504 +67
Branches 3899 3906 +7
==========================================
+ Hits 30677 30748 +71
+ Misses 2486 2473 -13
- Partials 1274 1283 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot. TODOs:
- Remove
if
s indocker-publish.yml
- Remove debug messages from
Dockerfile
- Only run
ctest
if tests were compiled
Signed-off-by: Johannes Kalmbach <[email protected]>
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
The cross-compilatiion currently takes more than 6 hours and is then cancelled by GitHub actions. We thus disable the building and execution of unit tests for the ARM64 build.
The cross-compilatiion currently takes more than 6 hours and is then cancelled by GitHub actions.
We thus disable the building and execution of unit tests for the ARM64 build.